fix: Harmonize SSO Buttons - #1012
Open
AyakorK wants to merge 1 commit into
Open
Conversation
AyakorK
marked this pull request as ready for review
July 29, 2026 13:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 Description
Unifies the SSO login button override mechanism across all omniauth providers. Previously each provider had its own strategy: FranceConnect hardcoded an image-only partial, Publik hacked the shared
log_in_with_providerTerm Customizer key, others only checkeddisplay_name, and the default fallback truncated the provider name ("France" instead of "France Connect").Now every provider goes through one cascade in
omniauth_provider_label: a per-provider Term Customizer translation →display_name-> a proper humanized name. Icon handling is unified too: any provider withicon_path+icon_hover_pathconfigured gets the full-image button treatment, and a safe generic icon fallback prevents crashes when nothing is configured, including a realNoMethodErrorcrash in decidim-core'soauth_iconfor any provider not registered inDecidim.omniauth_providers.Testing
decidim.devise.shared.links.provider_display_name_<provider>for a provider, run the GLOBAL cache cleaner (the term customizer "cache cleaner" button only clears the participatory processes related so it might not work), and confirm the button text updates📌 Related Issues
Tasks
omniauth_helper_spec.rb)log_in_with_providerandprovider_display_nameinconfig/i18n-tasks.ymlso they aren't flagged as unused, since they're referenced dynamically with an interpolated provider name rather than called literally in the code